Ensure flags isn't set to null if bootstrapping #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When upgrading from 1.7.0 to 2.1.2 we ran into an unexpected breaking change where although we bootstrap with localStorage, the flags would now be set to `null` leading to any calls to `variation` to throw until the client is fully ready. The behavior in the older version with the empty object allowed calls to `variation` to succeed before ready, but would simply use the default fallback value. This change restores that old behavior.
Contributor
|
Good catch, thanks. There should be a release with this fix shortly. |
Merged
eli-darkly
added a commit
that referenced
this pull request
Sep 7, 2018
reorganize and improve LDClient tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When upgrading from 1.7.0 to 2.1.2 we ran into an unexpected breaking change where although we bootstrap with localStorage, the flags would now be set to
nullleading to any calls tovariationto throw until the client is fully ready. The behavior in the older version with the empty object allowed calls tovariationto succeed before ready, but would simply use the default fallback value.This change restores that old behavior.